Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code fence attribute and instrument type names in Metrics and Tracing docs #43876

Open
antonfirsov opened this issue Dec 5, 2024 · 1 comment
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-fundamentals/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. Pri2

Comments

@antonfirsov
Copy link
Member

antonfirsov commented Dec 5, 2024

Describe the issue or suggestion

As #43872 (comment) pointed out, the current state is problematic:

For example, here the instrument type was overlocalized:

https://learn.microsoft.com/cs-cz/dotnet/core/diagnostics/built-in-metrics-aspnetcore#metric-aspnetcoreroutingmatch_attempts

And here, Boolean was overlocalized:

https://learn.microsoft.com/cs-cz/dotnet/core/diagnostics/built-in-metrics-aspnetcore#metric-httpserverrequestduration

And in German, string is overlocalized:

https://learn.microsoft.com/de-de/dotnet/core/diagnostics/built-in-metrics-aspnetcore#metric-httpserverrequestduration

Russian is even worse:

https://learn.microsoft.com/ru-ru/dotnet/core/diagnostics/built-in-metrics-aspnetcore#metric-httpserverrequestduration


Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@gewarren
Copy link
Contributor

gewarren commented Dec 5, 2024

@cmastr This would be a good one for vendors. They could either code fence, use xref links, or add no-loc metadata.

@gewarren gewarren added the doc-bug Problem with the content; needs to be fixed [org][type][category] label Dec 5, 2024
@dotnetrepoman dotnetrepoman bot removed the ⌚ Not Triaged Not triaged label Dec 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-fundamentals/svc okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. Pri2
Projects
None yet
Development

No branches or pull requests

2 participants