Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken build on VS 17.12.1 #18038

Closed
nbevans opened this issue Nov 20, 2024 · 5 comments
Closed

Broken build on VS 17.12.1 #18038

nbevans opened this issue Nov 20, 2024 · 5 comments
Labels
Milestone

Comments

@nbevans
Copy link

nbevans commented Nov 20, 2024

Please provide a succinct description of the issue.

net48 fsproj with websharper 4.x fails to build after VS 17.12.1 update

Provide the steps required to reproduce the problem:

We have a net48 project that is a <WebSharperProject>Library</WebSharperProject> near the top of the fsproj. This compiles to a WebSharper project which includes JS output.

If possible attach a zip file with the repro case. This often makes it easier for others to reproduce.
The zip file should ideally represent the situation just before the call/step that is problematic.

Expected behavior

Build should succeed like previous VS version

Actual behavior

Build is failing with, mainly, FS0039 errors. It simply cannot see types in other referenced fsproj files which is very bizarre. Visual Studio's code editor itself is not indicating any problems (no red squiggles on the same code that MSBuild is taking issue with.)

Known workarounds

None known

Related information

Provide any related information (optional):

  • Operating system = Windows 11
  • .NET Runtime kind (.NET Core, .NET Framework, Mono) = NetFx48
  • Editing Tools (e.g. Visual Studio Version, Visual Studio) = Visual Studio
@baronfel
Copy link
Member

I know websharper does it's own odd secondary compilation - you'll need to get a binlog (-bl) before we can do any kind of real analysis here. Pretty much any issue with a project using websharper should probably go to them first for triage before being routed here.

@nbevans
Copy link
Author

nbevans commented Nov 20, 2024

I've attached a binlog (albeit with a .txt extension)

sg.binlog.txt

It appears that there have been some breaking changes in this latest VS release that have broken this 4.x version of WebSharper. I will check out their Issues board also.

@nbevans
Copy link
Author

nbevans commented Nov 20, 2024

I can see the WsFsc.exe is being called correctly and all the arguments going into it (there are a lot) appear to be good. It certainly has all the -r to reference the expected projects in my solution.

A small utility WS project in the same solution builds fine (!) But this project doesn't reference any other projects in my solution. So the issue appears to be solely related to something with project references! How strange...

@nbevans
Copy link
Author

nbevans commented Nov 21, 2024

It seems to be related to the new MSBuild. If we compile with the older MSBuild (from VS Build Tools 17.10.9), the issue goes away. I'm not sure what to even search for on MSBuild issues forum. It's like they've changed the behaviour of and broken something with older tooling.

@abonie
Copy link
Member

abonie commented Nov 25, 2024

Can you please raise the issue at WebSharper and if it turns out to be compiler issue, please reopen with isolated F# compiler invocation

@abonie abonie closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants