Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-cleanup related to #6805 #8254

Merged
merged 2 commits into from
Jan 18, 2020
Merged

pre-cleanup related to #6805 #8254

merged 2 commits into from
Jan 18, 2020

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jan 17, 2020

This is a set of cosmetic changes factored out of #6805 to minimize the diff of that PR

cartermp
cartermp suggested changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xlf file changes need to be reverted; it's annoying how these are sometimes pulled along

KevinRansom
KevinRansom approved these changes Jan 18, 2020
View reviewed changes
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took care of reverting the .xlf files.

@KevinRansom
Copy link
Member

@cartermp I reverted the xlfs.

@KevinRansom KevinRansom merged commit 27d4652 into dotnet:master Jan 18, 2020
@dsyme
Copy link
Contributor Author

dsyme commented Jan 20, 2020

@cartermp I reverted the xlfs.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsyme @KevinRansom @cartermp