Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API support for SenseHat V2 Color Sensor TCS34725 #2088

Open
Ducki opened this issue Jun 14, 2023 · 5 comments
Open

API support for SenseHat V2 Color Sensor TCS34725 #2088

Ducki opened this issue Jun 14, 2023 · 5 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation Priority:3 Work that is nice to have up-for-grabs Good issue for external contributors to iot

Comments

@Ducki
Copy link

Ducki commented Jun 14, 2023

The revision 2 of the Raspberry Pi SenseHat has a color sensor TCS34725, which is currently unsupported in the SenseHat bindings.

The sensor itself is already implemented, but it would be nice, if it was usable via the SenseHat binding.

@Ducki Ducki added the api-suggestion Early API idea and discussion, it is NOT ready for implementation label Jun 14, 2023
@ghost ghost added the untriaged label Jun 14, 2023
@Ellerbach
Copy link
Member

Feel free to raise a PR to add it. We're not tracking the binding requests. So I'm leaving this one open a little bit but it will be closed in one of the next triage we'll collectively have.

@krwq krwq added Priority:3 Work that is nice to have and removed untriaged labels Jun 15, 2023
@krwq
Copy link
Member

krwq commented Jun 15, 2023

[Triage] You'll need to create something similar to https://github.com/dotnet/iot/blob/main/src/devices/SenseHat/SenseHatMagnetometer.cs and add property like this: https://github.com/dotnet/iot/blob/main/src/devices/SenseHat/SenseHat.cs#L48 - you need to find address first and handle errors in case someone is still using older version of SenseHat

@krwq krwq added the up-for-grabs Good issue for external contributors to iot label Jun 15, 2023
@Ducki
Copy link
Author

Ducki commented Jun 15, 2023

So while investigating, I found out that I was wrong about the sensor. The color sensor on the SenseHat seems to have changed recently to a different model: TSC3400 (which is not covered in the device bindings as of yet).

Source: astro-pi/python-sense-hat#126 (comment)

I'm sorry about that, but my low level skills aren't good enough to implement the other sensor. :)

@raffaeler
Copy link
Contributor

@Ducki All what we can do is leaving the ticket open for a while to see if there is someone owning the hardware and willing to contribute with a PR. If this doesn't happen, the issue will be closed.

@Ellerbach
Copy link
Member

TSC3400 (which is not covered in the device bindings as of yet).

I just checked and indeed, the sensors are different. The excellent news is that they are vey close. So it should be a matter of hours to adjust/adapt/extend the existing one to support the 3400 ones. 3400 seems to have Infra red as well. I don't have this sensor at all but I'm happy to support and help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation Priority:3 Work that is nice to have up-for-grabs Good issue for external contributors to iot
Projects
None yet
Development

No branches or pull requests

4 participants