[HybridWebView] Refactor and convert the HybridWebView.js file into a TypeScript file #27183
+396
−232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
requested review from
PureWeen and
jsuarezruiz
and removed request for
a team
mattleibow
force-pushed
the
dev/hybridwebview-embedded
branch
2 times, most recently
from
bc3d0eb to
b4ff555
Compare
mattleibow
changed the title
4 tasks
|
@MackinnonBuck I hear you are a super TS guru so I was wondering if you had some time to review this refactored code and let me know where I have done off the rails. |
mattleibow
force-pushed
the
dev/hybridwebview-embedded
branch
3 times, most recently
from
45919c9 to
cfa5963
Compare
mattleibow
changed the title
mattleibow
force-pushed
the
dev/hybridwebview-js-exceptions
branch
from
5b4193f to
1e26742
Compare
mattleibow
force-pushed
the
dev/hybridwebview-embedded
branch
from
cfa5963 to
e125fd3
Compare
mattleibow
force-pushed
the
dev/hybridwebview-embedded
branch
from
e125fd3 to
3a008dc
Compare
mattleibow
changed the base branch from
dev/hybridwebview-js-exceptions
to
main
Co-authored-by: Mackinnon Buck <[email protected]>
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR forms part of the effort to make the JS file injected into the app at runtime like the way Blazor works: #24730. However, this PR does not inject anything at this point, just compiles the TS file to JS as part of the build.
This PR only changes a few things:
Issues Fixed
Related to #24730