[Windows] Fix titlebar not persisting when page is swapped #27192
Conversation
Fix titlebar leaking events when replaced
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- src/Core/src/Platform/Windows/NavigationRootManager.cs: Evaluated as low risk
- src/Core/src/Platform/Windows/WindowRootView.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Controls/src/Core/Window/Window.cs:395
- Ensure that there are test cases covering the cleanup and reattachment of the title bar when the page is swapped.
prevTitleBar.Cleanup();
There was a problem hiding this comment.
Playing with this it seems like the TitleBar still disappears?
tested in the sandbox
return new Window(new NavigationPage(new MainPage()))
{
TitleBar = new TitleBar
{
BackgroundColor = Colors.Red,
ForegroundColor = Colors.White,
Subtitle = "Subtitle",
}
};Then in MainPage I swapped out the Page on Window
<VerticalStackLayout>
<Button Text="me" Clicked="Button_Clicked"></Button>
</VerticalStackLayout> private void Button_Clicked(object sender, EventArgs e)
{
this.Window.Page = new MainPage();
}The TitleBar seems to reset when the page is swapped
Nevermind..... |
Remove unneeded TB removal Add leak test
| @@ -120,7 +146,6 @@ public virtual void Disconnect() | |||
| } | |||
|
|
|||
| SetToolbar(null); | |||
| SetTitleBar(null, null); | |||
There was a problem hiding this comment.
Can we add this call up into the WindowHandler.Disconnect code?
I think it's still useful to set the TitleBar to null if the handler itself is being disconnected
so we can add it here
after the disconnect call
Description of Change
Issues Fixed
Fixes #27170