Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Proposal]: Breaking change - Make some types static #65909

Closed
Youssef1313 opened this issue Dec 9, 2022 · 2 comments · Fixed by #76040
Closed

[API Proposal]: Breaking change - Make some types static #65909

Youssef1313 opened this issue Dec 9, 2022 · 2 comments · Fixed by #76040
Labels
api-approved API was approved in API review, it can be implemented Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Milestone

Comments

@Youssef1313
Copy link
Member

Background and Motivation

See discussion in #65830

Proposed API

Namespace Microsoft.CodeAnalysis.VisualBasic
-     Partial Public Class SyntaxFacts
+     Partial Public NotInheritable Class SyntaxFacts
+         Private Sub New()
+         End Sub
      End Class
End Namespace
Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
-     Public Class SyntaxNodeRemover
+     Public NotInheritable Class SyntaxNodeRemover
+         Private Sub New()
+         End Sub
      End Class
End Namespace
namespace Microsoft.CodeAnalysis.CodeStyle
{
-     public class CodeStyleOptions
+     public static class CodeStyleOptions
      {
      }
}
@Youssef1313 Youssef1313 added Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request labels Dec 9, 2022
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 9, 2022
@333fred 333fred added the api-ready-for-review API is ready for review, it is NOT ready for implementation label Dec 13, 2022
@333fred
Copy link
Member

333fred commented Dec 13, 2022

Note, our next API review session isn't until Jan 5th (much of the office is out for US holidays), so it'll be a bit before we get to this.

@333fred
Copy link
Member

333fred commented Jan 5, 2023

API Review

  • First two are already static on the C# side, seems ok
  • Third has similar examples on other option holder types.

Conclusion: Approved.

@333fred 333fred added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review API is ready for review, it is NOT ready for implementation labels Jan 5, 2023
@arunchndr arunchndr added this to the 17.6 milestone Jan 6, 2023
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Jan 6, 2023
@arunchndr arunchndr modified the milestones: 17.6, Backlog Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-approved API was approved in API review, it can be implemented Area-IDE Concept-API This issue involves adding, removing, clarification, or modification of an API. Feature Request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants