Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Clean up fgGlobalMorph checks in morph #108875

Closed
jakobbotsch opened this issue Oct 15, 2024 · 1 comment · Fixed by #110218
Closed

JIT: Clean up fgGlobalMorph checks in morph #108875

jakobbotsch opened this issue Oct 15, 2024 · 1 comment · Fixed by #110218
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Milestone
10.0.0

Comments

@jakobbotsch
Copy link
Member

With #106695 we no longer call morph from CSE. It's likely some of these fgGlobalMorph existed only to filter out the calls from CSE, and if so, those checks can be removed.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 15, 2024
@jakobbotsch jakobbotsch added this to the 10.0.0 milestone Oct 15, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch jakobbotsch removed the untriaged New issue has not been triaged by the area owner label Oct 15, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Oct 15, 2024
@jakobbotsch jakobbotsch self-assigned this Oct 15, 2024
@jakobbotsch jakobbotsch mentioned this issue Nov 27, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI in-pr There is an active PR which will close this issue when it is merged
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

JIT: Remove references to "CSE candidate" in morph jakobbotsch/runtime
1 participant
@jakobbotsch