Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move R2RDump over to the new System.CommandLine #12766

Closed
AndyAyersMS opened this issue May 28, 2019 · 5 comments
Closed

Move R2RDump over to the new System.CommandLine #12766

AndyAyersMS opened this issue May 28, 2019 · 5 comments
Labels
area-R2RDump-coreclr Ready-to-run image dump tool
Milestone

Comments

@AndyAyersMS
Copy link
Member

The System.CommandLine used by R2RDump is a defunct corefxlabs project. We should move it over to using the new System.CommandLine.

Among other things this will unblock porting some of the jitutils over to this new command line parser (since PMI needs to be able to run in Core_Root environment). See dotnet/jitutils#209.

@AndyAyersMS
Copy link
Member Author

cc @trylek

I've been porting over jitutils so can do this too, if you like.

@AndyAyersMS
Copy link
Member Author

Here's my first attempt: R2RDumpNewCommandLine

I ended up moving all the command line stuff over to DumpOption. Had to rename some things to get their binding model working.

Feel free to give it a try. You will likely run into dotnet/command-line-api#532 so that needs to be fixed before we can move forward.

In particular using the [parse] directive is kind of interesting:

dotnet exec D:\repos\coreclr\bin\Product\Windows_NT.x64.Debug\netcoreapp2.0\R2RDump.dll [parse] --in foo.dll -x -v -d -q bar -q baz --diff
[ R2RDump [ --in <foo.dll> ] [ -x <True> ] [ -v <True> ] [ -d <True> ] [ -q <bar> <baz> ] [ --diff <True> ] ]

@trylek
Copy link
Member

trylek commented May 30, 2019

Thanks so much @AndyAyersMS, it looks great to me, feel free to merge it in if it works for you; I doubt there are too many other users of the tool out there right now and we / they should get easily adjusted to the new syntax. After all I believe the pre-existing command-line syntax is super-overcomplicated and I'd love to clean that up somehow, I'm just somehow lacking the spare cycles to look into that :-(.

@msftgits msftgits transferred this issue from dotnet/coreclr Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@ghost
Copy link

ghost commented Nov 30, 2023

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@ghost ghost added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Nov 30, 2023
@ghost
Copy link

ghost commented Dec 14, 2023

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@ghost ghost closed this as completed Dec 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2024
@ghost ghost removed no-recent-activity backlog-cleanup-candidate An inactive issue that has been marked for automated closure. labels Jan 13, 2024
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-R2RDump-coreclr Ready-to-run image dump tool
Projects
None yet
Development

No branches or pull requests

3 participants