Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Security.Cryptography.Xml feature requests #20429

Closed
1 of 14 tasks
krwq opened this issue Mar 3, 2017 · 3 comments
Closed
1 of 14 tasks

System.Security.Cryptography.Xml feature requests #20429

krwq opened this issue Mar 3, 2017 · 3 comments
Labels
area-System.Security enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@krwq
Copy link
Member

krwq commented Mar 3, 2017

This is an issue to collect all the feature requests after we finish stabilizing.
Some of them might be already implemented on Mono and might need a port.
cc: @anthonylangsworth @tintoy @peterwurzinger

Feature requests:

  • Add support for adding algorithms

Features resulting from failing tests: (there is no compat break between Desktop so marking as future) - they can be possibly Mono bugs

  • SignedXmlTest.DataReferenceToNonDataObject (There is an existing test with this - currently this is also not working on Desktop but likely is on Mono)
  • SignedXmlTest.GetIdElement_Null (throws ArgumentNullException on Desktop, seems to be valid on Mono)
  • SignedXmlTest.HmacMustBeMultipleOfEightBits (Desktop does not throw, Mono throws CryptographicException)
  • SignedXmlTest.VerifyHMAC_ZeroLength (Desktop does not throw, Mono throws CryptographicException)
  • SignedXmlTest.VerifyHMAC_SmallerThanMinimumLength (Mono has it with category "NotWorking") - verify if should be fixed
  • SignedXmlTest.VerifyHMAC_MinimumLength (Failing also on Desktop - seems to be passing on Mono)
  • SignedXmlTest.VerifyHMAC_SmallerHalfLength (Failing also on Desktop - seems to be passing on Mono)
  • SignedXmlTest.VerifyHMAC_HalfLength (Failing also on Desktop - seems to be passing on Mono)
  • SignedXmlTest.VerifyHMAC_HMACOutputLength_Signature_Mismatch (Failing also on Desktop - seems to be passing on Mono)
  • SignedXmlTest.VerifyHMAC_HMACOutputLength_Invalid (Failing also on Desktop - seems to be passing on Mono)
  • XmlDsigExcC14NWithCommentsTransformTest.LoadInputAsXmlNodeList, LoadInputAsXmlNodeList2 (Failing also on Desktop - seems to be working on Mono)
  • EncryptedXmlTest.GetDecryptionIV_StringNull (Failing also on Desktop - seems to be working on Mono) - Fix EncryptedXmlTest.GetDecryptionIV_StringNull and expand ExcryptedXmlTest corefx#17221
  • SignedInfoTest.GetXmlWithSetProperty (Failing also on Desktop - seems to be working on Mono)
@krwq krwq self-assigned this Mar 3, 2017
@karelz
Copy link
Member

karelz commented Mar 3, 2017

@krwq can you please triage the issue right away? (issue type, milestone) Thanks!

@krwq krwq removed their assignment Apr 5, 2017
@karelz
Copy link
Member

karelz commented May 1, 2017

See details in https://github.com/dotnet/corefx/issues/16594#issuecomment-298421865 on limitations of adding APIs into SignedXml/EncryptedXml - if we want to reboot the API surface and make it truly modern, we will have to create new package, which does not exchange types with .NET Framework inbox SignedXml/EncryptedXml. It may still compile from same source code though.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@bartonjs bartonjs removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2020
@bartonjs
Copy link
Member

It's been 7 years since this TODO list made progress. It's apparently about as done as it's ever going to get.

@bartonjs bartonjs closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Security enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

6 participants