Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set InstructionSet_EVEX flag in altjit. #108534

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Set InstructionSet_EVEX flag in altjit. #108534

merged 1 commit into from
Oct 28, 2024

Conversation

DeepakRajendrakumaran
Copy link
Contributor

Vector512 lowering/inlining is dependent on InstructionSet_EVEX being set. Currently we are not setting InstructionSet_EVEX when using altjit.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 3, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@DeepakRajendrakumaran DeepakRajendrakumaran marked this pull request as ready for review October 25, 2024 21:30
@tannergooding
Copy link
Member

CC. @dotnet/jit-contrib for secondary review

kunalspathak
kunalspathak approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunalspathak kunalspathak merged commit 2864ec4 into dotnet:main Oct 28, 2024
108 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepakRajendrakumaran @tannergooding @kunalspathak