Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implicit reference to Microsoft.AspNetCore.App.Internal.Assets #44997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add implicit reference to Microsoft.AspNetCore.App.Internal.Assets #44997

wants to merge 1 commit into from
+91 −2

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Nov 21, 2024 •
edited
Loading

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 21, 2024
@MackinnonBuck
Copy link
Member Author

Tested locally by building a local version of the SDK, manually making changes to the generated Microsoft.NETCoreSdk.BundledVersions.props file, copying the SDK to a locally-built version of ASP.NET Core, undoing the workaround here, and running a project generated by the Blazor Web App project template. Everything seemed to work (the fingerprinted blazor.web.js file was loaded and the binlog showed that the implicit project reference was being added), so I'm going to mark this PR as ready-for-review.

@MackinnonBuck MackinnonBuck marked this pull request as ready for review November 21, 2024 23:18
javiercn
javiercn reviewed Nov 22, 2024
View reviewed changes
src/Installer/redist-installer/targets/GenerateBundledVersions.targets
Comment on lines +593 to +596
<KnownAspNetCorePack Include="Microsoft.AspNetCore.App.Internal.Assets"
TargetFramework="net10.0"
AspNetCorePackVersion="$(MicrosoftAspNetCoreAppRuntimePackageVersion)" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only part I'm not 100% sure about. You can have an SDK and multiple runtimes. Meaning that you can have an install that has 1.0.0, 1.0.1, and 1.0.2 installed. 1.0.2 might be bundled, but your app might be using <FrameworkReference="Microsoft.AspNetCore.App" Version="1.0.0" /> or have it pinned in the global.json.

In that case shouldn't we respect that?

@maraf do you have any thoughts?

@MackinnonBuck MackinnonBuck mentioned this pull request Nov 22, 2024
Open
MihaZupan added a commit to MihaZupan/MihuBot that referenced this pull request Nov 23, 2024
@MihaZupan
Pin '10.0.0-alpha.1.24570.9' until dotnet/sdk#44997 is finalized
6bd60d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MackinnonBuck @javiercn