Some of profile attribute on files in windows desktop runtime pack are wrong

[ThomasGoulet73]

Description

Some of the files tagged as WinForms and WPF in #4227 are wrong, these are all WPF specific and are not used by WinForms:

windowsdesktop/src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Runtime.sfxproj

Lines 15 to 25 in 64fd833

	<FrameworkListFileClass Include="System.Xaml.resources.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="UIAutomationClient.resources.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="UIAutomationClientSideProviders.resources.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="UIAutomationProvider.resources.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="UIAutomationTypes.resources.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="WindowsBase.resources.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="WindowsFormsIntegration.resources.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="PenImc_cor3.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="vcruntime140_cor3.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Include="wpfgfx_cor3.dll" Profile="WindowsForms;WPF" />
	<FrameworkListFileClass Condition="'$(PlatformTarget)' != 'ARM64'" Include="D3DCompiler_47_cor3.dll" Profile="WindowsForms;WPF" />

The .resources.dll files in this bloc are tagged as WPF and WinForms when the regular dll is tagged as WPF only. Which means that in the publish you get the .resources.dll file without the matching .dll file.

For WindowsFormsIntegration.resources.dll it's unclear because the regular dll file is tagged as WPF and WinForms when AFAIK it shouldn't be used when it's WinForms only:

windowsdesktop/src/windowsdesktop/src/sfx/Directory.Build.props

Line 59 in 64fd833

<FrameworkListFileClass Include="WindowsFormsIntegration.dll" Profile="WindowsForms;WPF"/>

If I do the steps to reproduce in the issue dotnet/sdk#37088, I get those files in the output when they shouldn't be used at runtime.

/cc @LakshanF since you were the one to add the file.

[RussKie]

The change to how Windows Forms classifications are references was made incorrectly too: https://github.com/dotnet/windowsdesktop/pull/4227/files#r1791003324, and that should be rectified.

[lonitra]

This has been resolved via #4788. Created separate issue #4796 for rectifying how the winform classifications for the runtime pack is pulled in.