Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryFormatter error when Copy/Cut/Paste menu item in DemoConsole application #11617

Closed
elachlan opened this issue Jul 2, 2024 · 4 comments
Closed

BinaryFormatter error when Copy/Cut/Paste menu item in DemoConsole application #11617

elachlan opened this issue Jul 2, 2024 · 4 comments
Assignees
@LeafShi1
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization 💥 regression-preview Regression from a preview release
Milestone
9.0 RC1

Comments

@elachlan
Copy link
Contributor

elachlan commented Jul 2, 2024 •
edited
Loading

.NET version

.NET 9.0: Main branch

Did it work in .NET Framework?

Yes

Did it work in any of the earlier releases of .NET Core or .NET 5+?

n/a

Issue description

In DemoConsole test app of Winforms repo, BinaryFormatter error when clicking Copy/Cut/Paste commands for Menu Item.

image

Steps to reproduce

Test sample: DemoConsole in Winforms repo

Related: #6267 / #6269
@elachlan elachlan added untriaged The team needs to look at this issue in the next triage area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization 💥 regression-preview Regression from a preview release labels Jul 2, 2024
@elachlan elachlan changed the title BinaryFormatter error when copying menu item in DemoConsole application BinaryFormatter error when Copy/Cut/Paste menu item in DemoConsole application Jul 2, 2024
@LeafShi1
Copy link
Member

LeafShi1 commented Jul 3, 2024 •
edited
Loading

After PR #11540, the error System.PlatformNotSupportedException: 'BinaryFormatter serialization and deserialization have been removed. appears

Before this PR, executing Copy/Cut/Paste menu item would give a different error, the error was
image

@LeafShi1
Copy link
Member

This BinaryFormatter error disappear after add binary Formatter package (Related PR #11741)

@LeafShi1 LeafShi1 removed the untriaged The team needs to look at this issue in the next triage label Jul 24, 2024
@LeafShi1 LeafShi1 self-assigned this Jul 24, 2024
@lonitra
Copy link
Member

lonitra commented Jul 24, 2024

We're dependent on BinaryFormatter for CodeDomSerialization and adding the package fixes the issue

@lonitra lonitra closed this as completed Jul 24, 2024
@Zheng-Li01
Copy link
Member

Verified the issue on the latest DemoConsole test app of Winforms repo from main branch, it was fixed: no error when Copy/Cut/Paste menu item in DemoConsole application.
GHIssue11617

@MelonWang1 MelonWang1 modified the milestones: 9.0 Preview7, 9.0 RC1 Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LeafShi1 LeafShi1

Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization 💥 regression-preview Regression from a preview release
Projects
None yet
Milestone
9.0 RC1
Development

No branches or pull requests
5 participants
@elachlan @lonitra @Zheng-Li01 @MelonWang1 @LeafShi1