[release/9.0] Informational text in PrintPreviewControl has low contrast in basic and HightContrast themes. #12478
+33
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…any pages" in printPreviewControl has low color contrast (dotnet#12368) * fix dotnet#12365 [Accessibility] The text "Document does not contain any pages" in printPreviewControl has low color contrast * use SystemColor instead of hardcode
…4.5:1 for the text "Document does not contain any pages" in printPreviewControl (dotnet#12448) * fix 12441 [Accessibility] HC themes: The color contrast is less than 4.5:1 for the text "Document does not contain any pages" in printPreviewControl * fix unit tests * fix comments
src/System.Windows.Forms/src/System/Windows/Forms/Printing/PrintPreviewControl.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/9.0 #12478 +/- ##
=====================================================
+ Coverage 74.82815% 74.82903% +0.00088%
=====================================================
Files 3022 3022
Lines 630184 630210 +26
Branches 46788 46793 +5
=====================================================
+ Hits 471555 471580 +25
+ Misses 155247 155246 -1
- Partials 3382 3384 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@Epica3055 , @Tanya-Solyanik Is this pending testing or have we sent tactics mail? |
lonitra
added
the
📭 waiting-author-feedback
dotnet-policy-service
bot
added
untriaged
Tanya-Solyanik
added
Servicing-consider
|
@Epica3055 - had this PR been tested against the NET9 binaries? Once it is signed off, please send email to tactics using the PR description as the template, edit it as needed. |
Tanya-Solyanik
changed the title
Tanya-Solyanik
changed the title
Tanya-Solyanik
approved these changes
Nov 27, 2024
Tanya-Solyanik
added
the
🚫 * NO-MERGE *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12368 and #12448 to release/9.0
BUG: #12365, #12441
Bug Description
When
PrintPreviewControlhas no document to show, it shows a text message to that effect. This message has low color contrast ratio, making it hard to read. Text to background ratio is 2.3:1 or 3.9:1 in high contrast mode instead of the required 4.5:1 (https://www.w3.org/WAI/WCAG21/Understanding/contrast-minimum.html)Customer Impact
Accessibility requirement violation.
Regression?
no
Testing done
Risk
low, these colors are not under user control, they wouldn't interfere with user changes.
Microsoft Reviewers: Open in CodeFlow