Refactor DataFormats #12802
Merged
Refactor DataFormats #12802
+218
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare DataFormats to move core implementation to share with WPF. This splits the format list into two collections. The first is the known predefined format ids that come from Windows headers. The second collection contains ones that must be looked up. This optimizes allocations for typical user scenarios in WinForms and WPF. An internal interface is used to abstract the Format class. Next PR will move the shared logic into the shared assembly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12802 +/- ##
===================================================
+ Coverage 76.19998% 76.20955% +0.00956%
===================================================
Files 3197 3197
Lines 640529 640467 -62
Branches 47242 47221 -21
===================================================
+ Hits 488083 488097 +14
+ Misses 148913 148845 -68
+ Partials 3533 3525 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
lonitra
approved these changes
Jan 17, 2025
| /// <summary> | ||
| /// Typed interface for a data format that allows for creation. | ||
| /// </summary> | ||
| internal interface IDataFormat<T> : IDataFormat |
There was a problem hiding this comment.
Got to remember this as something that can be done, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare DataFormats to move core implementation to share with WPF.
This splits the format list into two collections. The first is the known predefined format ids that come from Windows headers. The second collection contains ones that must be looked up. This optimizes allocations for typical user scenarios in WinForms and WPF.
An internal interface is used to abstract the Format class.
Next PR will move the shared logic into the shared assembly.
Microsoft Reviewers: Open in CodeFlow