Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review use of BC41004 warning #3936

Open
RussKie opened this issue Sep 17, 2020 · 3 comments
Open

Review use of BC41004 warning #3936

RussKie opened this issue Sep 17, 2020 · 3 comments
Assignees
Milestone

Comments

@RussKie
Copy link
Member

RussKie commented Sep 17, 2020

The latest changes from dotnet/runtime (#3804) couldn't be merged due to build failures:

##[error]src\Microsoft.VisualBasic.Forms\src\Microsoft\VisualBasic\Devices\Network.vb(822,20): error BC41004: (NETCORE_ENGINEERING_TELEMETRY=Build) First statement of this 'Sub New' should be an explicit call to 'MyBase.New' or 'MyClass.New' because the 'Public Overloads Sub New()' in the base class 'WebClient' of 'WebClientExtended' is marked obsolete: 'Use HttpClient instead.'

The error was suppressed in 590399f.

The suppression needs to be reviewed, and corrected.

@RussKie RussKie added this to the 6.0 milestone Sep 17, 2020
@dreddy-work dreddy-work modified the milestones: 6.0, 7.0 Aug 27, 2021
@dreddy-work dreddy-work modified the milestones: .NET 7.0, .NET 8.0 Aug 15, 2022
@JeremyKuhne
Copy link
Member

@KlausLoeffelmann can you please validate that we don't need to do anything here?

@JeremyKuhne JeremyKuhne modified the milestones: .NET 8.0, .NET 8.0 RC2 Aug 16, 2023
@KlausLoeffelmann
Copy link
Member

@KlausLoeffelmann can you please validate that we don't need to do anything here?

Actually, we might need to do something here. I'll talk to @KathleenDollard when I am back in September, to discuss how we tackle this and the fact, that we also have problems still with ensuring Single-Instance in an RDP environment. This might be related, and we may need a different approach altogether.

@KlausLoeffelmann
Copy link
Member

This gets mitigated when we finish this #9807, which we cannot do in .NET 8.

@JeremyKuhne JeremyKuhne modified the milestones: .NET 9.0, Future Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants