Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reennable test broken in Merge and fix developer usability issues #12507

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

paul1956
Copy link
Contributor

@paul1956 paul1956 commented Nov 19, 2024

Stop ProgressDialog and VBInputBox from opening in designer which will fail.
Fix missing return in Interaction.vb

Fixes Issue where trying to open 2 VB Files in Designer causes designer to fail as its not supported (Don't know issue #)
Fact was missing from WindowsFormsApplicationBaseTests in Merge.

Proposed changes

  • Fix minor issue

Customer Impact

  • Improved test and WinForm Developers will not hang it they accidently try to open design files in Visual Studio

Regression?

  • Yes (test was accidently disabled) and No fixes usability issue

Risk

  • minimal
Microsoft Reviewers: Open in CodeFlow

Stop ProgressDialog and VBInputBox from opening in designer which will fail.
Fix missing return in Interaction.vb
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.75431%. Comparing base (cac5a6c) to head (bfb30ef).

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12507         +/-   ##
===================================================
- Coverage   75.75486%   75.75431%   -0.00055%     
===================================================
  Files           3159        3159                 
  Lines         635942      635944          +2     
  Branches       46987       46987                 
===================================================
- Hits          481757      481755          -2     
- Misses        150726      150730          +4     
  Partials        3459        3459                 
Flag Coverage Δ
Debug 75.75431% <78.94737%> (-0.00055%) ⬇️
integration 18.17899% <13.33333%> (+0.00031%) ⬆️
production 49.31545% <73.33333%> (-0.00176%) ⬇️
test 97.04702% <100.00000%> (+0.00110%) ⬆️
unit 46.53319% <73.33333%> (+0.00218%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

lonitra
lonitra previously approved these changes Nov 22, 2024
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PRs that are ready to merge but worth notifying the internal team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants