Add unit tests for ListControlStringCollectionEditor #12516
+70
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12516 +/- ##
===================================================
+ Coverage 75.01536% 75.74520% +0.72983%
===================================================
Files 3047 3158 +111
Lines 631584 636134 +4550
Branches 46764 47003 +239
===================================================
+ Hits 473785 481841 +8056
+ Misses 154434 150829 -3605
- Partials 3365 3464 +99
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Nora-Zhou01
added
the
waiting-review
lonitra
reviewed
Nov 22, 2024
| [Fact] | ||
| public void EditValue_WithNullContext_ReturnsBaseEditValue() | ||
| { | ||
| var editor = new ListControlStringCollectionEditor(typeof(string)); |
There was a problem hiding this comment.
Suggested change
| var editor = new ListControlStringCollectionEditor(typeof(string)); | |
| ListControlStringCollectionEditor editor = new(typeof(string)); |
Same in below tests as well
| public void EditValue_WithListControlAndNullDataSource_ReturnsBaseEditValue() | ||
| { | ||
| var editor = new ListControlStringCollectionEditor(typeof(string)); | ||
| ListBox listControl = new(); |
There was a problem hiding this comment.
Please dispose ListBox
Suggested change
| ListBox listControl = new(); | |
| using ListBox listControl = new(); |
| var provider = new Mock<IServiceProvider>().Object; | ||
| object? value = new(); | ||
|
|
||
| ArgumentException exception = Assert.Throws<ArgumentException>(() => editor.EditValue(context.Object, provider, value)); |
There was a problem hiding this comment.
Suggested change
| ArgumentException exception = Assert.Throws<ArgumentException>(() => editor.EditValue(context.Object, provider, value)); | |
| ArgumentException exception = ((Action)(() => editor.EditValue(context.Object, provider, value))).Should().Throw<ArgumentException>().Which; |
lonitra
added
📭 waiting-author-feedback
| @@ -0,0 +1,70 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
There was a problem hiding this comment.
When trying to run the tests myself i could not build the code with errors:
The "Csc" task could not be initialized with its input parameters.
The "InterceptorsNamespaces" parameter is not supported by the "Csc" task loaded from assembly: Microsoft.Build.Tasks.CodeAnalysis, Version=4.12.10.37901, Culture=neutral, PublicKeyToken=31bf3856ad364e35 from the path: C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24407.12\Microsoft.Build.Tasks.CodeAnalysis.dll. Verify that the parameter exists on the task, the <UsingTask> points to the correct assembly, and it is a settable public instance property.
I think that is due to the commit from which you checked out from to make the tests. I solved this by rebasing with the main branch on the runtime repo remote. You can do this:
gh pr checkout 12516 # If you are out of the branch now. I use github cli for this
git fetch --all
git pull --rebase $UPSTREAM_REMOTE main # $UPSTREAM_REMOTE should be the name of the remote where you're trying to send your PR to. As I work on my fork, mine is called `upstream`
git push --force| public void EditValue_WithNullContext_ReturnsBaseEditValue() | ||
| { | ||
| var editor = new ListControlStringCollectionEditor(typeof(string)); | ||
| var provider = new Mock<IServiceProvider>().Object; |
There was a problem hiding this comment.
Please declare variables with explicit types. This happens in other areas of the code as well.
| { | ||
| var editor = new ListControlStringCollectionEditor(typeof(string)); | ||
|
|
||
| ListBox listControl = new() { DataSource = new List<string> { "item1", "item2", "item3" } }; |
There was a problem hiding this comment.
Please dispose of this control with using
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow