Add unit tests for ToolStripActionList #12525
Open
+177
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12525 +/- ##
===================================================
+ Coverage 75.74163% 75.75632% +0.01469%
===================================================
Files 3157 3158 +1
Lines 636098 636207 +109
Branches 47003 47005 +2
===================================================
+ Hits 481791 481967 +176
+ Misses 150846 150777 -69
- Partials 3461 3463 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...Windows.Forms.Design/tests/UnitTests/System/Windows/Forms/Design/ToolStripActionListTests.cs
Outdated
Show resolved
Hide resolved
ricardobossan
added
📭 waiting-author-feedback
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
ricardobossan
previously approved these changes
Nov 22, 2024
lonitra
reviewed
Nov 22, 2024
| DesignerActionItemCollection items = _actionList.GetSortedActionItems(); | ||
| List<DesignerActionItem> itemList = items.Cast<DesignerActionItem>().ToList(); | ||
|
|
||
| itemList.Should().ContainSingle(i => i is DesignerActionMethodItem && ((DesignerActionMethodItem)i).MemberName == "InvokeEmbedVerb"); |
There was a problem hiding this comment.
I believe this can be simplified
Suggested change
| itemList.Should().ContainSingle(i => i is DesignerActionMethodItem && ((DesignerActionMethodItem)i).MemberName == "InvokeEmbedVerb"); | |
| itemList.Should().ContainSingle(i => i is DesignerActionMethodItem action && (action.MemberName == "InvokeEmbedVerb"); |
same can be applied in other places in this change
lonitra
added
the
📭 waiting-author-feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #10773
Proposed changes
Microsoft Reviewers: Open in CodeFlow