Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Python bindings code from Rust-only code #11

Closed
2 of 5 tasks
brandonwillard opened this issue Aug 21, 2024 · 0 comments · Fixed by #14
Closed
2 of 5 tasks

Separate Python bindings code from Rust-only code #11

brandonwillard opened this issue Aug 21, 2024 · 0 comments · Fixed by #14
Assignees
@brandonwillard @kc611
Labels
enhancement New feature or request help wanted Extra attention is needed TGI Related to the integration with `text-generation-inference`

Comments

@brandonwillard
Copy link
Member

brandonwillard commented Aug 21, 2024 •
edited by kc611
Loading

We want this library to (eventually) serve as a Rust-only crate with which one could construct an index without involving Python.

  • Separate PyO3 code from Rust-only code
    • Create distinct .rs files for PyO3 bindings
    • Make PyO3 an optional feature
    • Test Rust-only import of the outlines-core crate and make sure there's no PyO3 code/linking involved
  • Create Rust-only index construction function #9
@brandonwillard brandonwillard added enhancement New feature or request help wanted Extra attention is needed TGI Related to the integration with `text-generation-inference` labels Aug 21, 2024
@kc611 kc611 linked a pull request Aug 22, 2024 that will close this issue
Make PyO3 bindings an optional feature #14
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandonwillard brandonwillard

@kc611 kc611

Labels
enhancement New feature or request help wanted Extra attention is needed TGI Related to the integration with `text-generation-inference`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make PyO3 bindings an optional feature dottxt-ai/outlines-core
2 participants
@brandonwillard @kc611