Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Models in PDB #113

Closed
OWissett opened this issue Aug 25, 2023 · 1 comment · Fixed by #120
Closed

Bad Models in PDB #113

OWissett opened this issue Aug 25, 2023 · 1 comment · Fixed by #120

Comments

@OWissett
Copy link
Collaborator

PDB files are relatively poor in quality, generally speaking, and it isn't uncommon for PDB files to raise errors during parsing.

Notably, I have seen that quite a few PDB files often have issues relating to models, such as different models having numbers of atoms or residues (which is simply a result of the experiments done to get these files - I guess NMR?).

I propose that some sort of fallback strategy for loading PDBs with bad models should be implemented.

Most of the time, I only care about the first model in the file, so being able to load a file which would typically result in a PDB parsing failure, we could just ignore the other models.

To maintain backwards compatibility, we could maybe implement a new struct PdbLoadOptions or something similar, using a builder pattern to set pdb loading options.

This was referenced Aug 25, 2023
@douweschulte
Copy link
Owner

Sounds like a very good plan. I initially set out to make this fully compliant to spec, but as the rest of the world does not seem to hold the spec as dear it is better to make this library be able to hanled the structures from the rest of the world. I tried to give users the option for strict or loose parsing with the StrictnessLevel. Extending this to something like how you described it could be very useful.

@douweschulte douweschulte linked a pull request Apr 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants