-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass electron version to checkers #23
Comments
Just a quick summary of the current state and this issue:
Is this going to increase the overall complexity for just a minor performance gain? What do you think? Any additional benefit? |
It should increase complexity only slightly in some checkers as the number of differences in electron versions is still low. Plus an additional scan step is needed to read version first. However it is not about performance gain but about precision of analysis. For example it is planned in the future to change the default values of webpreferences. Settings parsing was fixed |
A design proposal for this issue was submitted in #58 (comment). |
Some differences between electron versions were already found like https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#browserwindow
and it is likely more will be found in the future.
The text was updated successfully, but these errors were encountered: