Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run bullmq test in github actions #4126

Closed
adiholden opened this issue Nov 13, 2024 · 5 comments · Fixed by #4565
Closed

run bullmq test in github actions #4126

adiholden opened this issue Nov 13, 2024 · 5 comments · Fixed by #4565
Assignees

Comments

@adiholden
Copy link
Collaborator

No description provided.

@chakaz
Copy link
Contributor

chakaz commented Dec 8, 2024

I was able to fix our bullmq-tests.yml such that installation of dependencies, build and running the tests work (the tests don't pass though):

main...chakaz/regtests-bullmq

Locally all tests pass, and I know that the BullMQ team also runs their releases against Dragonfly. However when running the tests in GitHub I get some failures. In Debug ~25, and in release ~5. I suspect this is mostly due to timeouts and very slow / busy runner machine.

Is there a way to use our dedicated machine for running this test? I'm not familiar with that area :|

@adiholden
Copy link
Collaborator Author

@chakaz can you create a PR I want to check running locally the workflow and see if this reproduces this fails

@chakaz
Copy link
Contributor

chakaz commented Dec 8, 2024

@adiholden #4275

@chakaz
Copy link
Contributor

chakaz commented Feb 5, 2025

Here's a full brain-dump of my current state of things:

  • I created a fork of bullmq with all required changes for the tests to pass: https://github.com/dragonflydb/bullmq
  • We have a github workflow for running bullmq tests (bullmq-tests), currently it's not scheduled automatically
  • I created a branch (chakaz/regtests-bullmq) with the required workflow .yml changes needed to get it to pass
  • There are, potentially, 2 things we can improve in the workflow (both are also in comments in the workflow):
    1. Build Dragonfly from main head instead of using the weekly container build
    1. Use BullMQ's latest version instead of our custom fork

@chakaz
Copy link
Contributor

chakaz commented Feb 5, 2025

Once #4565 is merged, we should be able to set up a scheduled run of the github workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants