Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add a daily coverage run #1437

Merged
merged 4 commits into from
Aug 22, 2023
Merged

chore: Add a daily coverage run #1437

merged 4 commits into from
Aug 22, 2023

Conversation

royjacobson
Copy link
Contributor

No description provided.

@royjacobson royjacobson force-pushed the daily_coverage branch 12 times, most recently from 4c1fe97 to a24f034 Compare June 19, 2023 19:21
@kostasrim kostasrim force-pushed the daily_coverage branch 4 times, most recently from 866a59f to 4eca093 Compare June 20, 2023 20:23
@royjacobson royjacobson changed the title lets try Trying to add coverage CI flow Jun 21, 2023
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/cov.yml Outdated Show resolved Hide resolved
@royjacobson royjacobson marked this pull request as ready for review August 14, 2023 16:26
@royjacobson royjacobson changed the title Trying to add coverage CI flow chore: Add a daily coverage run Aug 14, 2023
.github/workflows/cov.yml Outdated Show resolved Hide resolved
- name: Upload coverage
uses: actions/upload-artifact@v3
with:
name: coverage-report
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romange Roy told me that you figured out why we couldn't upload the coverage. Could you plz tell us here what the issue was ?

.github/workflows/cov.yml Show resolved Hide resolved
.github/workflows/cov.yml Outdated Show resolved Hide resolved
@kostasrim
Copy link
Contributor

Also I downloaded the produced artifact/ code coverage, everything seems to be ok!

Copy link
Contributor

@kostasrim kostasrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@royjacobson royjacobson merged commit d12c6e3 into main Aug 22, 2023
10 checks passed
@royjacobson royjacobson deleted the daily_coverage branch August 22, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants