test: fix and unskip test_migration_timeout_on_sync #4216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adiholden
reviewed
Nov 28, 2024
| ) | ||
|
|
||
| logging.debug("debug migration resume") | ||
| await nodes[1].client.execute_command("debug migration resume") | ||
|
|
||
| await wait_for_status(nodes[0].admin_client, nodes[1].id, "FINISHED") | ||
| await wait_for_status(nodes[0].admin_client, nodes[1].id, "FINISHED", 300) |
There was a problem hiding this comment.
this test runs around 300 seconds?
If you have 3 seconds timeout flag why do you need migration that takes this long to test this logic?
There was a problem hiding this comment.
If the test takes 300 seconds can we plz optimize this? Ideally <1Min
There was a problem hiding this comment.
it runs less than a minute, I just set a little more)
adiholden
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #4047