Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Modify the content of the selection selected by the formula, and the options are not updated. #1866

Open
2 tasks done
zhaolixin7 opened this issue Apr 11, 2024 · 3 comments

Comments

@zhaolixin7
Copy link

zhaolixin7 commented Apr 11, 2024

在您提交此问题之前,您是否检查了以下内容?

  • 这真的是个问题吗?
  • 我已经在 Github Issues 中搜索过了,但没有找到类似的问题。

受影响的包和版本

dev

复现链接

1、新建下拉选项,引用数据中输入公式=OFFSET(E1,0,1,6,1)
2、修改OFFSET公式
3、修改引用选区或删除列

预期行为

1、修改公式,引用数据下显示引用的引用选项(公式的结果)
2、下拉选项更新、引用数据中也更新

实际行为

2024_4_11.16_57_23.video.webm

运行环境

No response

系统信息

No response

@zhaolixin7 zhaolixin7 added bug Something isn't working scope:data validation labels Apr 11, 2024
@univer-bot univer-bot bot changed the title [Bug] 修改公式引用选区的内容,选项未更新 [Bug] Modify the content of the selection selected by the formula, and the options are not updated. Apr 11, 2024
@univer-bot
Copy link

univer-bot bot commented Apr 11, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: [Bug] 修改公式引用选区的内容,选项未更新

Title: [Bug] Modify the content of the selection selected by the formula, and the options are not updated.


Before you submitted this question, did you check the following?

  • Is this really a problem?
  • I've searched Github Issues but haven't found any similar issues.

Affected packages and versions

dev

Recurrence link

  1. Create a new drop-down option and enter the formula =OFFSET(E1,0,1,6,1) in the reference data.
  2. Modify the OFFSET formula
  3. Modify the reference selection or delete the column

Expected behavior

  1. Modify the formula and display the reference option (the result of the formula) under the reference data.
  2. The drop-down options are updated and the reference data is also updated.

Actual behavior

2024_4_11.16_57_23.video.webm

Running environment

No response

system message

No response

@Dushusir
Copy link
Member

Dushusir commented Jun 19, 2024

  1. 已经在 fix(formula): remove non-existent formula ids #2531 中修复
  2. FormulaRefRangeService 中 sequenceNodesBuilder 对 formula string 的解析不完全,解析不到 OFFSET/INDIRTECT 等返回 referenceObject 的范围,导致没有监听到范围变更,故需要公式引擎提供另外一个方法,将公式关联的所有范围提取出来,未来也可以复用到数据透视表等地方,用于引用数据的范围变更监听。 @DR-Univer @weird94
    企业微信截图_17187672921368

@univer-bot
Copy link

univer-bot bot commented Jun 19, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

  1. Already fixed in fix(formula): remove non-existent formula ids #2531
  2. The sequenceNodesBuilder in FormulaRefRangeService does not completely parse the formula string, and cannot parse the range of referenceObject returned by OFFSET/INDIRTECT, etc., resulting in no monitoring of range changes. Therefore, the formula engine needs to provide another method to extract all ranges associated with the formula. In the future, it can also be reused in places such as pivot tables for scope change monitoring of referenced data. @DR-Univer @weird94
    Enterprise WeChat screenshot_17187672921368

@Dushusir Dushusir added scope:formula feature request New feature or request and removed bug Something isn't working labels Jun 19, 2024
@wzhudev wzhudev assigned Dushusir and unassigned DR-Univer Jun 26, 2024
@Dushusir Dushusir assigned DR-Univer and unassigned Dushusir Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants