Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can it be counted only when the call is successful? #10

Open
jianmaikj opened this issue Oct 13, 2021 · 1 comment
Open

Can it be counted only when the call is successful? #10

jianmaikj opened this issue Oct 13, 2021 · 1 comment

Comments

@jianmaikj
Copy link

Summary

SUMMARY_GOES_HERE

@chirag-manwani
Copy link
Collaborator

Yes, this is a valid point. We could check for response status and increment the counter only if the status is 2XX. Is there any other case where the response is non 2XX but we still want to increment the request count?
We could add a setting in the plugin schema as well which could be used to turn this behaviour on or off.

@jianmaikj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants