Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kong Plugin Feature Parity #13

Open
TimUnderhay opened this issue Mar 9, 2022 · 3 comments
Open

Kong Plugin Feature Parity #13

TimUnderhay opened this issue Mar 9, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@TimUnderhay
Copy link

Summary

Thanks for the work on this plugin. I suppose this is both a question and a feature request. Comparing the docs and code of this vs the native rate limiting plugin, I notice that the below config features are not present in this plugin. Are there plans to sync the functionality?

The official Kong plugin docs say "You can combine consumer.id, service.id, or route.id in the same request, to further narrow the scope of the plugin". I specifically need the ability to target both a consumer.id and a service.id simultaneously. Is this planned?

  • limit_by values: consumer, credential, ip, path. I am particularly interested in consumer.
  • service_id
  • consumer.id
  • route.id
  • path

Thanks in advance!

@chirag-manwani
Copy link
Collaborator

Hi @KensingtonTech this is a genuine feature request and we would definitely want to add it to the plugin. Could you come up with a rough plan of what changes would be required for this? A PR would be highly welcome.

@chirag-manwani chirag-manwani added the enhancement New feature or request label Mar 10, 2022
@TimUnderhay TimUnderhay removed their assignment Mar 10, 2022
@TimUnderhay
Copy link
Author

@chirag-manwani Apologies, I wasn't volunteering to take the lead on it. I was just asking if it was planned.

@chirag-manwani
Copy link
Collaborator

No worries. I will update here once we plan to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants