Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snags with text fields on configuration page #48

Open
tintori opened this issue Apr 21, 2019 · 5 comments
Open

Snags with text fields on configuration page #48

tintori opened this issue Apr 21, 2019 · 5 comments

Comments

@tintori
Copy link
Collaborator

tintori commented Apr 21, 2019

I ran into a few of glitches when configuring a project this time around, all having to do with the text fields acting funny. Here they are in descending order of significance.

  1. I wanted to add hyperlink URL and names to all three project.JSON files, but those text fields still aren't accepting input.
    (Perhaps for now I can just tell you what goes in there and you can type it into the project.JSON files directly?

  2. The new grid.csv input field creates a glitch only when testing the configuration. I think maybe the program gets confused about how to override your default compact grid feature. Once you save it out and reload the home page, though, it all works swimmingly.

  3. The min and max fields don't let you type a negative sign unless there's other text in the box already. It's navigable, but I always end up typing 4 instead of -4, and then having to go back and fix it.

@tintori tintori added this to the Finish project milestone Apr 21, 2019
@tintori
Copy link
Collaborator Author

tintori commented Apr 21, 2019

Oh, one more little glitch I ran into while configuring a project—

  1. When I hit the "Test" button to review my configuration, if I went to the menu to click on the "About this dataset" link, instead of being send to the README.md file I had just uploaded, I got routed back to the configuration page.

@ptgolden ptgolden removed the broken? label Apr 23, 2019
@ptgolden
Copy link
Collaborator

I wanted to add hyperlink URL and names to all three project.JSON files, but those text fields still aren't accepting input.

Fixed in 99b3498

(Perhaps for now I can just tell you what goes in there and you can type it into the project.JSON files directly?

You could do that on Dropbox

The new grid.csv input field creates a glitch only when testing the configuration. I think maybe the program gets confused about how to override your default compact grid feature. Once you save it out and reload the home page, though, it all works swimmingly.

The min and max fields don't let you type a negative sign unless there's other text in the box already. It's navigable, but I always end up typing 4 instead of -4, and then having to go back and fix it.

If you have workarounds for these, I'll fix them later

When I hit the "Test" button to review my configuration, if I went to the menu to click on the "About this dataset" link, instead of being send to the README.md file I had just uploaded, I got routed back to the configuration page.

Thanks, I'll take note

@ptgolden
Copy link
Collaborator

OK I updated the editing form and the project configuration files. The others I will do when I have time

@tintori
Copy link
Collaborator Author

tintori commented Apr 23, 2019

Ok, sounds good.

Yea, I would have added the hyperlinks to the treatment.json files in Dropbox myself, but didn't know what the required keys would be, since there wasn't a template I could look at. Thanks for adding them.

@ptgolden
Copy link
Collaborator

I'm going to take this out of the "finish project" milestone because the other issues listed here are just annoying, not "show stoppers"

@ptgolden ptgolden removed this from the Finish project milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants