Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PubsubClient #80

Open
jordy25519 opened this issue Nov 29, 2024 · 0 comments · May be fixed by #82
Open

Fix PubsubClient #80

jordy25519 opened this issue Nov 29, 2024 · 0 comments · May be fixed by #82

Comments

@jordy25519
Copy link
Collaborator

The pubsub client provided by solana/agave crates fails silently: https://github.com/anza-xyz/agave/blob/79c0fe5c7cfc94e921a104c4e51e2e27aee9d821/pubsub-client/src/nonblocking/pubsub_client.rs#L489
It also does not provide any method to handle disconnection events.

To work around this drift-rs eagerly initializes new PubSubClient instances when a disconnect is detected.

  1. Its not clear that all disconnects are being detected properly
  2. each instance of PubSubClient creates its own Ws connection with various overhead such as ping messages, etc.

Ideally, drift-rs would multiplex a minimal number of Ws Connections and handle the disconnections properly
@jordy25519 jordy25519 linked a pull request Dec 2, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/pubsub client drift-labs/drift-rs
1 participant
@jordy25519