Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pubsub client #82

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix/pubsub client #82

wants to merge 5 commits into from

Conversation

jordy25519
Copy link
Collaborator

@jordy25519 jordy25519 commented Dec 2, 2024

Changes

  • classes with WebSockets now receive an Arc<PubsubClient> to better share the underlying resource
  • drift-rs has its own modified PubsubClient with reconnection handling
  • the client will manage the underlying Ws. Consumer can decide what their connection guarantees/config will be e.g. failfast, exponential backoff. resubscription on disconnects will happen transparently.

TODO:

  • resubscription api/management is clunky (make it event driven?) rn subscribers eagerly attempt to resubscribe after a disconnect

closes #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PubsubClient
1 participant