Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix filler configs #318

Open
wphan opened this issue Dec 16, 2024 · 0 comments
Open

fix filler configs #318

wphan opened this issue Dec 16, 2024 · 0 comments

Comments

@wphan
Copy link
Member

wphan commented Dec 16, 2024

Looks like some boolean logic got clobbered, ensure the following configs are handled correctly:

  • botConfigs.*filler*.revertOnFailure: if true should always include the revert ix
    • currently this defaults to true, and some how gets stripped out if global.hermesEndpoint is NOT defined
    • if true, should be present for both tx simulation and final landed tx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wphan