Update dependencies #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` e: dependency-guard\dependency-guard\build.gradle.kts:91:9: None of the following functions can be called with the arguments supplied: public operator fun DependencyAdder.invoke(dependencyNotation: CharSequence): Unit defined in org.gradle.kotlin.dsl public operator fun DependencyAdder.invoke(dependency: Dependency): Unit defined in org.gradle.kotlin.dsl public operator fun DependencyAdder.invoke(files: FileCollection): Unit defined in org.gradle.kotlin.dsl public operator fun DependencyAdder.invoke(dependency: Provider<out Dependency>): Unit defined in org.gradle.kotlin.dsl public operator fun DependencyAdder.invoke(externalModule: ProviderConvertible<out MinimalExternalModuleDependency>): Unit defined in org.gradle.kotlin.dsl ```
|
There is one last thing to do, which is to update the "Adding to the Buildscript Classpath". To me, there is no point of adding the plugin to the classpath this way since we already show how to add it with: plugins {
id("com.dropbox.dependency-guard") version "..."
}Or is it used for something else I did not thought about? The Legacy Plugin API using the buildscript block feels outdated and is probably no longer used for people wanting to test the snapshot versions. Could we replace it with something like this? Using SNAPSHOT versionsSnapshot versions are under development and change, but can be used by adding in the snapshot repository // settings.gradle.kts
pluginManagement {
repositories {
maven { url = uri("https://s01.oss.sonatype.org/content/repositories/snapshots") }
}
}
// build.gradle.kts
plugins {
id("com.dropbox.dependency-guard") version "x.y.z-SNAPSHOT"
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also migrates the 2 remaing Groovy Gradle build files to kts.