-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we want to include additional dependencies? #12
Comments
|
we haven't put views_cache_bully into production yet, so I would feel better about battle hardening that option a bit more. |
Group, As a high level goal here... we should only include extra things here if they are going to be used in almost all of our builds. I'm not sure things like globalredirect and page_title fit the bill but i defer to you guys. Another high level goal is stability. Let's try to only include stable modules or beta's with great support and activity. I want kalatheme and hotsauce to be lean and fit not a bloated hot_mess. @reynoldsalec, can you "should i stay or should i go?" this? |
Agreed @pirog, I think everything mentioned so far is a shoo-in, with the exceptions of transliteration and coffee. I know @bassettsj and @mmenavas like coffee, anyone else in support? Anything that transliteration is good for on every site (I've only used it for specialized cases)? What does better_formats give us? Remember using it in D6 but not so much in D7. |
Transliteration assures that image files names uploaded with uppercase or stupid non-ascii characters (like accents) get transformed using (ideally) pathauto settings. Also fixes spaces in filename issues that %20 but cause issues on some browser/OS versions. Better formats lets us set per field text format prefs which is not only useful, but should be done. See more info in my doc I A also added filefield_paths which lets us use more than completely bogus tokens so images get uploaded to /images/[node-type]/[upload-year]/. Retroactive update option on the content type will move and re-organize all images to a cleaner destination. There's a ton of crap that goes right into /files/ in the build process and that should generally not happen. More info in my doc |
Ok, those make more sense now @andrewmallis. Just noticed field_collection was in the list; that we'll leave out for the time being, it's an architectural decision that's not necessary on every site. Complete list:
|
field_collection is required by some widgets in play, including hot_buttons |
Hmm, perhaps we should include that in the makefile for hot_buttons. @andrewmallis let's continue this conversation on #11, I'd rather not have field_collection in core HotSauce requirement unless we have a really good reason. |
I also have a deep hatred for field collections so would prefer not to On Wed, Jun 25, 2014 at 10:22 AM, reynoldsalec [email protected]
Cheers, Mike Pirog |
@andrewmallis is right about the field_collection dependency, but I think it is really unstable and finky. A lot of the current hot apps I think will need to be refactored anyways, at least I hope. I think leaving it out and just having that be a dependency for hot apps is fine. |
I think that is a good intermediate resolution. Maybe open a new issue to discuss how to deal with FC in the future (aka get rid of it). |
I was going to suggest adding ECK to the list but the new branch (7.x-3.x) which is going to have major improvements (i.e. property widgets and entity reference behavior) is not ready yet. |
One thing that ECK may be useful for is potentially replacing the need for field_collection. I think @reynoldsalec mentioned ECK being poor in the UX area. Maybe @mmenavas could investigate it as a replacement? thoughts? |
ECK is awesome, but unless we have a ton of dependencies that demand it, we won't be using it on more than 50% of our current projects. Feel the same way about Field Collections right now. If we develop a bunch of apps and widgets that require ECK or Field Collections, we'll include them in HotSauce! core. Definitely keep waving the ECK flag @mmenavas, but we should push it in the HotApps! space. |
We'll need to remove icon + speedy once we have kalatheme_dependencies setup and include that. |
We'll handle re-shuffling of dependencies in #8. |
Are there other modules/features that we want to include with hotsauce by default? What are they?
@bassettsj @andrewmallis @reynoldsalec discuss!
The text was updated successfully, but these errors were encountered: