Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length check for Malformed response #2572

Open
stanley101music opened this issue Sep 29, 2024 · 0 comments
Open

Length check for Malformed response #2572

stanley101music opened this issue Sep 29, 2024 · 0 comments

Comments

@stanley101music
Copy link

Which version are you referring to
3.2

I'm currently reviewing the part of checking $tls_serverhello_ascii_len to determine whether it's a Malformed response or not.
The specific lines are #14260~#14264 and #14303~#14306

AFAIK, the code checks the ServerHello message's length while the condition ensures that the message's length must be larger than the minimum size of the ServerHello message structure, i.e., 76 in this case.
However, the comments present that without sid-len, there are at least 40 bytes, and thus I'd expect the threshold of the length check should be 40*2= 80.

I'd like to know why it's 76 instead of 80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant