Card 를 구현한다. #35
Merged
Card 를 구현한다. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
soyi47
approved these changes
May 8, 2023
| render: () => ( | ||
| <Card | ||
| size="small" | ||
| cardNumber={11112} |
There was a problem hiding this comment.
얘 카드 번호 왜 넣다 말았어요? ㅋㅋㅋㅋㅋㅋ 작은 카드는 번호 나오다 말길래 문제 있는 줄 알았슴다 ㅋㅋㅋㅋㅋ
There was a problem hiding this comment.
숫자가 입력되는 과정을 보여주려고 했습니다ㅋㅋ
Comment on lines
13
to
47
| const cardSizeConfig = { | ||
| small: { | ||
| width: 152, | ||
| height: 100, | ||
| padding: 10, | ||
| fontSize: 10 | ||
| }, | ||
| medium: { | ||
| width: 208, | ||
| height: 130, | ||
| padding: 14, | ||
| fontSize: 14 | ||
| }, | ||
| large: { | ||
| width: 300, | ||
| height: 183, | ||
| padding: 20, | ||
| fontSize: 18 | ||
| } | ||
| }; | ||
|
|
||
| const icChipConfig = { | ||
| small: { | ||
| width: 30, | ||
| height: 20 | ||
| }, | ||
| medium: { | ||
| width: 40, | ||
| height: 26 | ||
| }, | ||
| large: { | ||
| width: 55, | ||
| height: 35 | ||
| } | ||
| }; |
liswktjs
requested changes
May 14, 2023
| size="small" | ||
| cardNumber={11112} | ||
| expirationDate={{ month: '04', year: '24' }} | ||
| ownerName={'김윤진'} |
There was a problem hiding this comment.
윤진씨 카드군요 ㅋㅋㅋㅋㅋㅋㅋㅋ 괜히 웃기네요 그런데 디자인 시스템 배포 될 예정인데 실명 들어가도 상관 없으신가요? ㅋㅋㅋㅋ
Comment on lines
+14
to
+31
| small: { | ||
| width: 152, | ||
| height: 100, | ||
| padding: 10, | ||
| fontSize: 10 | ||
| }, | ||
| medium: { | ||
| width: 208, | ||
| height: 130, | ||
| padding: 14, | ||
| fontSize: 14 | ||
| }, | ||
| large: { | ||
| width: 300, | ||
| height: 183, | ||
| padding: 20, | ||
| fontSize: 18 | ||
| } |
There was a problem hiding this comment.
카드 사이즈는 정말.... custom하게 해주지 맙시다 이게 좋을듯 하핫 👍
Comment on lines
40
to
43
| cardNumber={1111222233334444} | ||
| expirationDate={{ month: '04', year: '24' }} | ||
| ownerName={'김윤진'} | ||
| cardType={{ name: '하나카드', color: 'green' }} |
There was a problem hiding this comment.
이 요소들은 storybook에서 직접 바꿔서 값 넣어볼 수 있게 해주는게 좋을 것 같습니다!
Comment on lines
+43
to
+46
| <CardNumber size={size}>{cardNumbers[0]}</CardNumber> | ||
| <CardNumber size={size}>{cardNumbers[1]}</CardNumber> | ||
| <CardNumber size={size}>{cardNumbers[2].replace(/./g, '*')}</CardNumber> | ||
| <CardNumber size={size}>{cardNumbers[3].replace(/./g, '*')}</CardNumber> |
There was a problem hiding this comment.
요기는 ref 까지는 굳이 넣어줄 필요 없겠죠? 궁금하네요 필요성의 여부... 어떻게 생각하시나요?
There was a problem hiding this comment.
넣어줘야 하는 이유가 있나요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
card 컴포넌트 구현했습니다. 딱히 특이사항은 없는 것 같네요.
close #34