Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the naming convention of co-located components/tests #581

Open
travi opened this issue Oct 28, 2019 · 0 comments
Open

improve the naming convention of co-located components/tests #581

travi opened this issue Oct 28, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@travi
Copy link
Member

travi commented Oct 28, 2019 •
edited
Loading

  • index.js in a component directory should only be a manifest to enable importing by directory rather than component file
  • since there aren't really any container components in this project, the distinction between presentational and container isnt valuable. use component.js and component-test.js instead
@travi travi added the help wanted Extra attention is needed label Oct 31, 2019
travi added a commit that referenced this issue Oct 31, 2019
@travi
wip(naming-convention): updated atoms to more consistent convention
9c900c7 
for #581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@travi