Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vorpal.parse() method has breaking changes to behaviour in 1.11.4 #172

Closed
allmarkedup opened this issue Aug 8, 2016 · 2 comments
Closed

Comments

@allmarkedup
Copy link

v1.11.4 seems to have had a breaking change in the behaviour of the vorpal.parse(). Prior to this version this method parsed the command string but did not attach a UI, which was great because (as I was using it) commands could be triggered directly if required (for instance when running tasks on a server), instead of dropping into 'interactive mode'.

Since 1.11.4 this is no longer the case. Is this change intentional (if so I feel like it requires a major version bump as this is certainly a breaking change) or an unintended consequence of another change?

@dthree
Copy link
Owner

dthree commented Aug 8, 2016

We're about to fix this. Please see this existing issue:

#169

@allmarkedup
Copy link
Author

Ah perfect - I must have somehow missed the other issue in my skim through the list. Good to know that you are on it.

Vorpal is awesome, btw. Great work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants