Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues while upgrading the package for Angular 6++? #130

Closed
trtin opened this issue May 7, 2018 · 7 comments
Closed

Issues while upgrading the package for Angular 6++? #130

trtin opened this issue May 7, 2018 · 7 comments

Comments

@trtin
Copy link

trtin commented May 7, 2018

Hi,

It's work perfect under v.6. But after moment update to latest version of Angular, issues happen with fs, crypto, stream and Buffer ... seems from Node libraries.

Does anyone have same issues and already solve it, please?

Thanks in advance.

@trtin
Copy link
Author

trtin commented May 7, 2018

Solved by using /browser instead of /lib ...

But need to be confirmed if its right.

Thanks.

@trtin
Copy link
Author

trtin commented May 7, 2018

It happens JQc is not defined

any ideas please ?

@smoke
Copy link
Contributor

smoke commented May 11, 2018

I am also struggling with that and looking for solutions.

smoke added a commit to smoke/xlsx-populate that referenced this issue May 14, 2018
it seems some of the old referenced packages were producing bad builds
of `browser/*` that caused problems like `JQc is not defined`
see dtjohnson#130 (comment)
smoke added a commit to smoke/xlsx-populate that referenced this issue May 14, 2018
@smoke
Copy link
Contributor

smoke commented May 15, 2018

I have some progress and I am working on a PR, but I am having issues.

Meanwhile here is what I found and the current status:

smoke added a commit to smoke/xlsx-populate that referenced this issue May 15, 2018
it seems some of the old referenced packages were producing bad builds
of `browser/*` that caused problems like `JQc is not defined`
see dtjohnson#130 (comment)
see mishoo/UglifyJS#2783
see dtjohnson#124
smoke added a commit to smoke/xlsx-populate that referenced this issue May 16, 2018
it seems some of the old referenced packages were producing bad builds
of `browser/*` that caused problems like `JQc is not defined`
see dtjohnson#130 (comment)
see mishoo/UglifyJS#2783

fixes dtjohnson#115
fixes dtjohnson#124
fixes dtjohnson#125
fixes dtjohnson#130
smoke added a commit to smoke/xlsx-populate that referenced this issue May 16, 2018
it seems some of the old referenced packages were producing bad builds
of `browser/*` that caused problems like `JQc is not defined`
see dtjohnson#130 (comment)
see mishoo/UglifyJS#2783

fixes dtjohnson#115
fixes dtjohnson#124
fixes dtjohnson#125
fixes dtjohnson#130
@dtjohnson
Copy link
Owner

Please try with v1.17.0. There is also a non-minified version available now.

@smoke
Copy link
Contributor

smoke commented May 28, 2018

I confirm the JQc is not defined problem is fixed with the new version, however I still had to point to the specific version of xlsx-populate that I wanted to use in my tsconfig.app.json like so:

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/app",
    "baseUrl": "./",
    "module": "es2015",
    "types": [],
    "paths": {
      "xlsx-populate": [
        "../node_modules/xlsx-populate/browser/xlsx-populate-no-encryption.min.js"
      ]
    }
  },
  "angularCompilerOptions": {
    "preserveWhitespaces": true
  },
  "exclude": [
    "test.ts",
    "**/*.spec.ts"
  ]
}

@Akxe
Copy link

Akxe commented Feb 3, 2021

@smoke It solved the problem with angular not compiling, but it did mess up my type declarations :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants