You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
removeLayout(layout) is called, then layoutStorage.remove(layout) is called
We delete this.states[layout.id]
layoutStorage.save() is called, then this.storage.setItem
Expected behavior:
After deleting the layout from states, I'd expect this.storage.removeItem() to be called, though I'm not really sure what the intended behavior of that method is other than to handle mismatched hashes.
Using anything other than localStorage, and storing layouts individually, it becomes a pain to detect when a layout was removed, since at present it calls this.storage.setItem as any other change would. Further, it doesn't seem that removeItem is ever realistically called when using dashboard-layouts.
The text was updated successfully, but these errors were encountered:
Current behavior:
removeLayout(layout)
is called, thenlayoutStorage.remove(layout)
is calledthis.states[layout.id]
layoutStorage.save()
is called, thenthis.storage.setItem
Expected behavior:
After deleting the layout from
states
, I'd expectthis.storage.removeItem()
to be called, though I'm not really sure what the intended behavior of that method is other than to handle mismatched hashes.Using anything other than localStorage, and storing layouts individually, it becomes a pain to detect when a layout was removed, since at present it calls
this.storage.setItem
as any other change would. Further, it doesn't seem thatremoveItem
is ever realistically called when usingdashboard-layouts
.The text was updated successfully, but these errors were encountered: