Skip to content

Latest commit

 

History

History
55 lines (45 loc) · 2.71 KB

TRIAGING.md

File metadata and controls

55 lines (45 loc) · 2.71 KB
Raw

Triage new issues/PRs on github

This document shows the steps the Angular team is using to triage issues. The labels are used later on for planning releases.

Tips

  • install github pr helper extension and become 356% more productive
  • Label "resolution:*"
    • these tags can be used for labeling a closed issue/PR with a reason why it was closed. (we can add reasons as we need them, right there are only a few rejection reasons. it doesn't make sense to label issues that were fixed or prs that were merged)

Process

  1. Open list of non triaged issues

  2. Assign yourself: Pick an issue that is not assigned to anyone and assign it to you

  3. Assign milestone:

    • "Docs only" milestone - for documentation PR -> Done.
    • Current/next milestone - regressions
    • 1.2.x - everything else

  4. Label "GH: *" (to be automated via Mary Poppins)

    • PR - issue is a PR
    • issue - otherwise

  5. Bugs:

    • Label "Type: Bug"
    • Label "Type: Regression" - if the bug is a regression
    • Duplicate? - Check if there are comments pointing out that this is a dupe, if they do exist verify that this is indeed a dupe and close it and go to the last step
    • Reproducible? - Steps to reproduce the bug are clear, if not ask for clarification (ideally plunker or fiddle)
    • Reproducible on master? - http://code.angularjs.org/snapshot/

  6. Non bugs:

    • Label "Type: Feature" or "Type: Chore"
    • Label "needs: breaking change" - if needed
    • Understandable? - verify if the description of the request is clear. if not ask for clarification
    • Goals of angular core? - Often new features should be implemented as a third-party module rather than an addition to the core.

  7. Label "component: *"

    • In rare cases, it's ok to have multiple components.

  8. Label "impact: *"

    • small - obscure issue affecting one or handful of developers
    • medium - impacts some usage patterns
    • large - impacts most or all of angular apps

  9. Label "complexity: *"

    • small - trivial change
    • medium - non-trivial but straightforward change
    • large - changes to many components in angular or any changes to $compile, ngRepeat or other "fun" components

  10. Label "PRs welcome" for "GH: issue"

    • if complexity is small or medium and the problem as well as solution are well captured in the issue

  11. Label "cla: yes" for "GH: PR":

    • otherwise prompt the contributor to sign the CLA

  12. Label "origin: google" for issues from Google

  13. Label "high priority" for security issues, major performance regressions or memory leaks

  14. Unassign yourself from the issue