From ecbdb6c13e6c5ae4cc33535b62cf7f9e63fcfb16 Mon Sep 17 00:00:00 2001
From: Cris Barreiro <cbarreiro@duckduckgo.com>
Date: Thu, 1 Aug 2024 16:52:27 +0200
Subject: [PATCH] Fix buttons cut off in Dialog single choice landscape

---
 .../res/layout/dialog_single_choice_alert.xml | 20 +++++++------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/common/common-ui/src/main/res/layout/dialog_single_choice_alert.xml b/common/common-ui/src/main/res/layout/dialog_single_choice_alert.xml
index 243065533dd4..c04cc3d141a2 100644
--- a/common/common-ui/src/main/res/layout/dialog_single_choice_alert.xml
+++ b/common/common-ui/src/main/res/layout/dialog_single_choice_alert.xml
@@ -54,7 +54,9 @@
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintHeight_max="@dimen/dialogRadioGroupHeightMax"
         app:layout_constraintStart_toStartOf="parent"
-        app:layout_constraintTop_toBottomOf="@id/radioListDialogMessage">
+        app:layout_constraintTop_toBottomOf="@id/radioListDialogMessage"
+        app:layout_constraintBottom_toTopOf="@id/radioListDialogPositiveButton"
+        android:layout_marginBottom="@dimen/keyline_4">
 
         <RadioGroup
             android:id="@+id/radioListDialogRadioGroup"
@@ -67,42 +69,34 @@
         android:id="@+id/radioListDialogPositiveButton"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginTop="@dimen/keyline_4"
         android:text="Positive"
         app:layout_constraintBottom_toBottomOf="parent"
-        app:layout_constraintEnd_toEndOf="parent"
-        app:layout_constraintTop_toBottomOf="@+id/radioListDialogContent"/>
+        app:layout_constraintEnd_toEndOf="parent"/>
 
     <com.duckduckgo.common.ui.view.button.DaxButtonDestructive
         android:id="@+id/radioListDialogDestructivePositiveButton"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginTop="@dimen/keyline_4"
         android:text="Positive"
         app:layout_constraintBottom_toBottomOf="parent"
-        app:layout_constraintEnd_toEndOf="parent"
-        app:layout_constraintTop_toBottomOf="@+id/radioListDialogContent"/>
+        app:layout_constraintEnd_toEndOf="parent"/>
 
     <com.duckduckgo.common.ui.view.button.DaxButtonGhost
         android:id="@+id/radioListDialogNegativeButton"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginTop="@dimen/keyline_4"
         android:layout_marginEnd="@dimen/keyline_2"
         android:text="Cancel"
         app:layout_constraintBottom_toBottomOf="parent"
-        app:layout_constraintEnd_toStartOf="@+id/radioListDialogPositiveButton"
-        app:layout_constraintTop_toBottomOf="@+id/radioListDialogContent"/>
+        app:layout_constraintEnd_toStartOf="@+id/radioListDialogPositiveButton"/>
 
     <com.duckduckgo.common.ui.view.button.DaxButtonGhost
         android:id="@+id/radioListDestructiveDialogNegativeButton"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_marginTop="@dimen/keyline_4"
         android:layout_marginEnd="@dimen/keyline_2"
         android:text="Cancel"
         app:layout_constraintBottom_toBottomOf="parent"
-        app:layout_constraintEnd_toStartOf="@+id/radioListDialogDestructivePositiveButton"
-        app:layout_constraintTop_toBottomOf="@+id/radioListDialogContent"/>
+        app:layout_constraintEnd_toStartOf="@+id/radioListDialogDestructivePositiveButton"/>
 
 </androidx.constraintlayout.widget.ConstraintLayout>
\ No newline at end of file