Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declarativeNetRequestWithHostAccess permission is needed for modifyHeaders and redirect #1

Open
xeenon opened this issue Mar 22, 2023 · 2 comments

Comments

@xeenon
Copy link

xeenon commented Mar 22, 2023

Regarding FB12074754 and FB12074747, a change was made to align with Chrome that requires the declarativeNetRequestWithHostAccess permission for redirect and modifyHeaders dNR actions.

https://github.com/sammacbeth/mv3-compat-tests/blob/367cf7dbe15b201fc8d4a5f5850f867819f8a28c/Shared%20(Extension)/Resources/manifest.json#L40-L45

@xeenon xeenon changed the title declarativeNetRequestWithHostAccess permission is needed for modifyHeaders declarativeNetRequestWithHostAccess permission is needed for modifyHeaders and redirect Mar 22, 2023
@xeenon
Copy link
Author

xeenon commented Mar 22, 2023

@sammacbeth

@sammacbeth
Copy link
Collaborator

Thanks for this @xeenon. I added the declarativeNetRequestWithHostAccess to the manifest and now those issues are mostly resolved (addOrReplaceParams does not seem to work though).

I'm not sure this behavior is entirely aligned with Chrome, as the original manifest permissions were sufficient for redirect and modifyHeaders DNR rules. Perhaps, declarativeNetRequest permission and <all_urls> host permissions is sufficient, and the additional declarativeNetRequestWithHostAccess is considered redundant in this case. I'll check if that is the case, then raise a WECG issue to document the inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants