Add Client.from_env constructor #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bh2smith
force-pushed
the
dune-from-env
branch
2 times, most recently
from
de20925 to
c077028
Compare
bh2smith
force-pushed
the
upload-csv
branch
2 times, most recently
from
9628db7 to
75c3f6c
Compare
bh2smith
force-pushed
the
dune-from-env
branch
from
d2959ad to
4be18a2
Compare
bh2smith
force-pushed
the
dune-from-env
branch
from
4be18a2 to
6a529d9
Compare
msf
reviewed
Sep 6, 2023
msf
reviewed
Sep 6, 2023
bh2smith
force-pushed
the
dune-from-env
branch
from
6a529d9 to
d6e34d4
Compare
|
I have addressed all comments and suggestions. No more |
|
I am going to assume this is alright since I have addressed the comments & suggestions made by @msf. I'll wait a bit and merge tomorrow morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will simplify the user experience, not needing to import env vars manually (putting it all under the hood). Should pave the way for making documentation easier.
Closes #68
cc @TheEdgeOfRage & @diegoximenes for additional review.