Re-index kyberswap contracts

[nhd98z]

Hi @Hosuke , I see there are some lacks and some wrong contract indexes in dune production, I need to reindex kyberswap contracts as mentioned below. Can you help?

select blockchain, address, name, namespace from evms.contracts where name like 'AggregationRouter' and namespace like '%kyber%';

Actual:
bnb         0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
ethereum    0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
arbitrum    0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouter kyber
polygon     0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
avalanche_c 0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouter kyber

Expected:
bnb         0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
ethereum    0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
polygon     0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
avalanche_c 0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
fantom      0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber

Explaination: 0x00555513acf282b42882420e5e5ba87b44d8fa6e is AggregationRouterV3

select blockchain, address, name, namespace from evms.contracts where name like 'AggregationRouterV2' and namespace like '%kyber%';

Actual:
ethereum    0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber
polygon     0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber
bnb         0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber

Expected:
ethereum    0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber
polygon     0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber
bnb         0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber
arbitrum    0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber
avalanche_c 0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber
fantom      0xdf1a1b60f2d438842916c0adc43748768353ec25 AggregationRouterV2 kyber

Explaination: Lack of arbitrum, avalanche_c, fantom

select blockchain, address, name, namespace from evms.contracts where name like 'AggregationRouterV3' and namespace like '%kyber%';

Actual:
optimism    0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
ethereum    0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
bnb         0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
fantom      0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
polygon     0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber

Expected:
optimism    0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
ethereum    0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
bnb         0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
fantom      0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
polygon     0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
arbitrum    0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber
avalanche_c 0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouterV3 kyber

Explaination: Lack of arbitrum, avalanche_c

select blockchain, address, name, namespace from evms.contracts where name like 'MetaAggregationRouter' and namespace like '%kyber%';

Actual:
avalanche_c 0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
optimism    0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
optimism    0x180555d4d45e67520adc7c0c51b512c7a50877f2 MetaAggregationRouter kyberswap
arbitrum    0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
polygon     0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
fantom      0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
ethereum    0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
bnb         0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber

Expected:
avalanche_c 0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
optimism    0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
arbitrum    0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
polygon     0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
fantom      0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
ethereum    0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber
bnb         0x617dee16b86534a5d792a4d7a62fb491b544111e MetaAggregationRouter kyber

Explaination: 0x180555d4d45e67520adc7c0c51b512c7a50877f2 is our staging contract, so you can remove it

select blockchain, address, name, namespace from evms.contracts where name like 'MetaAggregationRouterV2' and namespace like '%kyber%';

Actual:
optimism    0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyberswap
ethereum    0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
fantom      0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
arbitrum    0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
avalanche_c 0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
optimism    0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
polygon     0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
bnb         0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber

Expected:
ethereum    0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
fantom      0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
arbitrum    0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
avalanche_c 0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
optimism    0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
polygon     0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber
bnb         0x6131b5fae19ea4f9d964eac0408e4408b66337b5 MetaAggregationRouterV2 kyber

Explaination: Duplicate optimism 0x6131b5fae19ea4f9d964eac0408e4408b66337b5 kyberswap

[Hosuke]

This issue may link to contract decoding. I will try to inform the team.

[jeff-dude]

yes, let's loop in @antonio-mendes for when he is back next week. thanks for bringing it up!

[nhd98z]

Hi @antonio-mendes, please notify me if you have updated this.

[antonio-mendes]

@nhd98z thanks for the clear description on what needed to be fixed. It really made my life easier!

I've just pushed all the changes and they'll be live in the next couple of hours. When you have time please take a look and let me know if everything is looking as expected.

As an heads up for at least 1 contract I had to keep it decoded under 2 names so I don't break spellbook. If I were to rename the contract before we merge a change on Spellbook to fix the source to the name you suggested above the next Spellbook run would fail. Once we merge the migration and latest PRs for Kyberswap I can go in and clean up the old naming to avoid any future issues/confusion.

If you have any question lmk

[nhd98z]

Thanks @antonio-mendes 👍 .

[nhd98z]

TODO: #4161 (comment)

select blockchain, address, name, namespace from evms.contracts where name like 'AggregationRouter' and namespace like '%kyber%';

Actual:
bnb         0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
ethereum    0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
arbitrum    0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouter kyber
polygon     0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
avalanche_c 0x00555513acf282b42882420e5e5ba87b44d8fa6e AggregationRouter kyber

Expected:
bnb         0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
ethereum    0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
polygon     0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
avalanche_c 0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber
fantom      0x1fc3607fa67b58deddb0faf7a116f417a20c551c AggregationRouter kyber

Explaination: 0x00555513acf282b42882420e5e5ba87b44d8fa6e is AggregationRouterV3

[antonio-mendes]

This is now fixed 👍
https://dune.com/dune/is-my-contract-decoded-yet-v2?contract_ta8992=0x00555513acf282b42882420e5e5ba87b44d8fa6e