Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sanctum router to solana dex trades #7188

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

senyor-kodi
Copy link

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

Add Sanctum Router to dex_solana.trades

Copy link

github-actions bot commented Nov 25, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@senyor-kodi
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 25, 2024
@jeff-dude
Copy link
Member

welcome to spellbook!

you are correct, the issue here is memory related and cluster crashing. this is not uncommon for solana data 🥲

my recommendation for dev and testing phase is to hardcode a short timeframe filter to reduce data volume heavily. rule of thumb: any time you add an incremental filter, that's a good indication to add hardcoded filter outside for historical run for last ~few weeks or so. that should help get CI running end-to-end

@jeff-dude jeff-dude added WIP work in progress dbt: solana covers the Solana dbt subproject labels Nov 25, 2024
@senyor-kodi
Copy link
Author

Hey jeff, adding a time filter for last week did it!

Had to fix a couple typos before all checks passed but seems to be good now. Do I need to do anything else on my end? Should I keep the time filter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: solana covers the Solana dbt subproject WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants