-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Safe on Ethereum Balances #6392
Conversation
Workflow run id 10005575837 approved. |
Workflow run id 10005576029 approved. |
Workflow run id 10029444725 approved. |
Workflow run id 10029444779 approved. |
Workflow run id 10029532940 approved. |
Workflow run id 10029533067 approved. |
Workflow run id 10039945491 approved. |
Workflow run id 10039945661 approved. |
Workflow run id 10039977807 approved. |
Workflow run id 10039978023 approved. |
Workflow run id 10040029584 approved. |
Workflow run id 10040029443 approved. |
Added token balance
Workflow run id 10042220946 approved. |
Workflow run id 10042221522 approved. |
@jeff-dude what am I missing here? |
looks like the error only appears on incremental run, and only one block of incremental code in the model. i'm not sure why the engine is throwing that generic error, but we don't use the |
Changed Incremental command
Workflow run id 10052609558 approved. |
Workflow run id 10052609604 approved. |
Workflow run id 10052742433 approved. |
@jeff-dude I think that the incremental command is an issue here for this context. I'm forward filling the balances for safes that didn't have their balances changed during their days, so every day will require us to look at the past data to determine the day's data. What would you suggest here if that is true? a balances difference table? |
dbt_subprojects/hourly_spellbook/models/_project/safe/ethereum/safe_ethereum_balances.sql
Outdated
Show resolved
Hide resolved
…/safe_ethereum_balances.sql Co-authored-by: jeff-dude <[email protected]>
Workflow run id 10156353388 approved. |
Workflow run id 10156353484 approved. |
It worked!! Thank you |
Workflow run id 10156414144 approved. |
Workflow run id 10156414264 approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this model to the schema file in directory path too?
https://github.com/duneanalytics/spellbook/blob/main/dbt_subprojects/hourly_spellbook/models/_project/safe/ethereum/safe_ethereum_schema.yml
dbt_subprojects/hourly_spellbook/models/_project/safe/ethereum/safe_ethereum_balances.sql
Outdated
Show resolved
Hide resolved
dbt_subprojects/hourly_spellbook/models/_project/safe/ethereum/safe_ethereum_balances.sql
Show resolved
Hide resolved
Changed to day from timestamp
Workflow run id 10200071911 approved. |
Workflow run id 10200072100 approved. |
added balances schema
Workflow run id 10200264602 approved. |
Workflow run id 10200264934 approved. |
hey @jeff-dude sorry I am not clear how to update the schema and prices. Can you tell me how to do that? |
Workflow run id 10200564455 approved. |
Workflow run id 10200564941 approved. |
let me take over and push some changes, to give you an example. keep a close eye on the commits so it's easier for ya next time 🙏 |
thanks @jeff-dude! Reading your commits so that I can successfully create future spells |
Thank you for contributing to Spellbook 🪄
Contribution type
Please check the type of contribution this pull request is for:
Note: You can safely discard any section below which doesn't apply based on selection above
For new spell(s)
If you are building new spell(s), please provide the following information:
For adding to existing spell lineage
If you are adding to an existing spell lineage, please provide the following information:
For bug fixes
If you are fixing a bug, please provide the following information:
Additional information
Please provide any additional information that might help us review your pull request:
Thank you for your contribution!