-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply gap testing to prices table #7060
Open
Hosuke
wants to merge
12
commits into
duneanalytics:main
Choose a base branch
from
Hosuke:1030-prices-gap-test-dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems the tests in the subproject |
This reverts commit 7c66052.
There are missing days in |
Duped in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dbt: tokens
covers the Tokens dbt subproject
ready-for-review
this PR development is complete, please review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
dbt_subprojects/tokens
project, focusing on adding data tests for price models and ensuring no missing prices for different time intervals. Additionally, it re-enables the test paths configuration.Data tests for price models:
dbt_subprojects/tokens/models/prices/_schema.yml
: Addeddbt_utils.unique_combination_of_columns
data tests forprices_daily
,prices_hourly
, andprices_minute
models to ensure unique combinations ofblockchain
,contract_address
, andtimestamp
. [1] [2] [3]Ensuring no missing prices:
dbt_subprojects/tokens/tests/assert_no_missing_prices_day.sql
: Added a SQL test to ensure there are no missing daily prices for each token.dbt_subprojects/tokens/tests/assert_no_missing_prices_hour.sql
: Added a SQL test to ensure there are no missing hourly prices for each token.dbt_subprojects/tokens/tests/assert_no_missing_prices_minute.sql
: Added a SQL test to ensure there are no missing minute-level prices for each token.dbt_subprojects/tokens/tests/schema.yml
: Added schema definitions for the new data tests to ensure no missing prices at daily, hourly, and minute levels.Configuration updates:
dbt_subprojects/tokens/dbt_project.yml
: Re-enabled thetest-paths
configuration to include thetests
directory.