Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list routes for scrapers and properties #9

Closed
2 tasks
dunlas opened this issue Sep 16, 2023 · 1 comment · Fixed by #16
Closed
2 tasks

Add list routes for scrapers and properties #9

dunlas opened this issue Sep 16, 2023 · 1 comment · Fixed by #16
Assignees
@dunlas
Labels
feature New feature or request
Milestone
1.0

Comments

@dunlas
Copy link
Owner

dunlas commented Sep 16, 2023 •
edited
Loading

Implement a list route where a list of the scraper and property route can be given. This also needs to implement filters to minimize the rows to display. Edit: Filters will be implemented later when fastapi-filters gets pydantic >= 2.0 support

Defaults: 10 items, sort by updated newest to oldest
Filters can be set in a front end application

  • Scrapers list route
  • Properties list route
@dunlas dunlas added the task Something that needs to be done (not a new feature) label Sep 16, 2023
@dunlas dunlas added this to the v1.0.0 milestone Sep 16, 2023
@dunlas dunlas self-assigned this Sep 16, 2023
@dunlas dunlas added feature New feature or request and removed task Something that needs to be done (not a new feature) labels Sep 16, 2023
@dunlas
Copy link
Owner Author

dunlas commented Sep 17, 2023

So for filtering I want to use fastapi-filtering, however this is not available for pydantic >2.0.0 as of right now. There is currently a pull request open to bump the verision but it is not yet merged. arthurio/fastapi-filter#447

dunlas pushed a commit that referenced this issue Sep 17, 2023
Refs: #9 - Removed unused imports
b7f138f
dunlas pushed a commit that referenced this issue Sep 17, 2023
Refs: #9 - Implemented scraper list route to get all scrapers
5ebaf86
dunlas pushed a commit that referenced this issue Sep 17, 2023
Refs: #9 - Added get by id route and list route for Property API
a1431eb
@dunlas dunlas mentioned this issue Sep 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dunlas dunlas

Labels
feature New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Feature/9 add list routes dunlas/rest-scraper
1 participant
@dunlas